Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get-DiskByIdentifier: Allow selection based on Serial Number #260

Closed
wants to merge 3 commits into from
Closed

Get-DiskByIdentifier: Allow selection based on Serial Number #260

wants to merge 3 commits into from

Conversation

bozho
Copy link

@bozho bozho commented Nov 10, 2021 •
edited by PlagueHO
Loading

Pull Request (PR) description

This PR introduces support for using disk serial number as a disk identifier in disk-related resources Disk, DiskAccessPath and WaitForDisk.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@bozho
Copy link
Author

bozho commented Nov 10, 2021

Need to add more tests

@PlagueHO PlagueHO added enhancement The issue is an enhancement request. abandoned The pull request has been abandoned. labels Jan 26, 2023
@PlagueHO
Copy link
Member

PlagueHO commented Feb 7, 2023

This has been superseded by #271 .

@PlagueHO PlagueHO closed this Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
abandoned The pull request has been abandoned. enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get-DiskByIdentifier: Allow selection based on Serial Number
2 participants
@bozho @PlagueHO